Undeploy command ignores invalid input

lightbend / cloudflow

Cloudflow enables users to quickly develop, orchestrate, and operate distributed streaming applications on Kubernetes.

https://cloudflow.io

Apache License 2.0

321 stars 90 forks source link

Undeploy command ignores invalid input #166

Closed mrooding closed 4 years ago

mrooding commented 4 years ago

Describe the bug A typo in the question of whether or not the user would like to remove PVCs and Kafka topics leads to undesired behaviour if the user tried to type 'yes'.

To Reproduce Answer the question with something other than 'yes' or 'no'

Expected behavior Request new input from the user which matches the 2 options

Screenshots

Additional context Add any other context about the problem here.

yuchaoran2011 commented 4 years ago

Closing this issue. In Cloudflow 1.3.1, we have changed to remove all dependent k8s resources (identified via owner references set on them) when an application is undeployed.