search

lightbend / cloudflow

Cloudflow enables users to quickly develop, orchestrate, and operate distributed streaming applications on Kubernetes.
https://cloudflow.io
Apache License 2.0
321 stars 90 forks source link

Namespace for protocol version configmap is hardcoded #6

Closed skonto closed 4 years ago

skonto commented 5 years ago

Describe the bug The namespace for the protocol version configmap cloudflow-protocol-version is hardcoded to lightbend. If the lightbend namespace doesn't exist, the configmap is not created, and the CLI cannot be used. It should not be hardcoded.

To Reproduce Install Cloudflow on a namespace different than lighbend (can be changed in install-gke.sh).

Run kubectl cloudflow list.

It fails with

[Error] Cannot find the 'cloudflow-protocol-version' configmap, please make sure that the Cloudflow operator is installed

workaround: create a lightbend namespace, and kill the cloudflow-operator pod to restart it.

Expected behavior The configmap to be installed and looked for in the current namespace.

Screenshots N/A Additional context N/A

Thank you @skyluc for reporting this.

mrooding commented 4 years ago

This can be closed since #45 was merged?

RayRoestenburg commented 4 years ago

I agree, this can be closed. @skonto @debasishg