search

lightbend / config

configuration library for JVM languages using HOCON files
https://lightbend.github.io/config/
6.12k stars 968 forks source link

Handle one simple case of resolving list of += values which #783

Closed Dkhusainov closed 1 year ago

Dkhusainov commented 1 year ago

Fixes #729 and significantly improves parsing of configs which have many += array concatenations(large play application with many play.modules.enabled, for example)

lightbend-cla-validator commented 1 year ago

At least one commit author (d.khusainov@infotech.team) is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

ennru commented 1 year ago

We do not intend to extend the functionality of "Typesafe Config" further. See https://github.com/lightbend/config#maintained-by

tmccombs commented 7 months ago

@ennru Does fixing bugs fall under "extend functionality"?

ennru commented 7 months ago

Does fixing bugs fall under "extend functionality"?

It may be hard to draw the line where bugs end and new functionality starts. We want to be very conservative not to change things that worked in a certain way, even if some may agree the way it worked is wrong.

tmccombs commented 7 months ago

I agree with that in general. But to me at least, "stack overflow on valid input" is very far on the bug side. I guess if you want to draw that line so far back that not even crashing the JVM is considered a bug, that is your choice. Although, it does make me a little sad, since I think that hocon is a great configuration language.

And I'm glad that I found this before putting the effort into trying to put together a PR to fix #800 (which is probably related to this).

tmccombs commented 7 months ago

Also, I totally understand that there aren't a lot of resources available to continue work on this library. And I appreciate the work that you have put into this project. I just want to understand better what exactly is meant by "feature complete", so I can know if it is worth my time to submit pull requests to fix things that I consider to be bugs.

ennru commented 7 months ago

I bulk closed PRs at the time as we want to be clear that Typesafe Config is not to evolve further. If you are up for it, I agree that this is something that would be worth fixing.