search

lightbend / fdp-sample-applications

All sample applications for Fast Data Platform
Apache License 2.0
15 stars 6 forks source link

WiP refinements to the README and app-install.sh #4

Closed deanwampler closed 6 years ago

deanwampler commented 6 years ago

Added the ability to specify what app(s) to install when running apps/bin/app-install.sh. Refined the README, too. WiP because the build may not work yet (no Docker images were uploaded; can't understand why) and the deployed KillrWeather appears broken.

Don't merge yet.

deanwampler commented 6 years ago

I think this is ready to merge. Boris said he would work on the bugs in how KillrWeather is built.

blublinsky commented 6 years ago

Debasish, https://github.com/lightbend/fdp-sample-applications/blob/develop/apps/sbt-common-settings/settings/DockerAssemblySettings.scala#L22 is causing me a bit of problem. I do not like to put my jars along with Sparks. The worse part is that I do not see my jar there, for the killrweather. Can you take a look?

deanwampler commented 6 years ago

Like this approach or not ;) it appears that it simply may not work. The jars are missing when I attempt to run...

deanwampler commented 6 years ago

I'm going to merge this PR, so it will be the baseline you can work with tomorrow. Note the enhancements to apps/bin/app-install.sh for specifying the app(s) to install.