search

lightbend / genjavadoc

A compiler plugin for generating doc’able Java source from Scala source
Other
58 stars 32 forks source link

Support Scala 2.12.10 #194

Closed wangyum closed 5 years ago

wangyum commented 5 years ago

This PR makes it support Scala 2.12.10.

Scala 2.12.10 release notes:

More details: https://github.com/scala/scala/releases/tag/v2.12.10

lightbend-cla-validator commented 5 years ago

Hi @wangyum,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

wangyum commented 5 years ago

I have signed the CLA.

wangyum commented 5 years ago

cc @SethTisue @dwijnand

SethTisue commented 5 years ago

genjavadoc releases have usually been done by @2m, but he's no longer at Lightbend

@patriknw is there somebody else on the Akka team who could take on this responsibility...?

raboof commented 5 years ago

@SethTisue I think I've done one before, happy to give it a go again.

dongjoon-hyun commented 5 years ago

Thank you, @wangyum , @raboof and @SethTisue !

raboof commented 5 years ago

looking into https://github.com/lightbend/genjavadoc/issues/193 before releasing though

dongjoon-hyun commented 5 years ago

Great! Thank you all!