search

lightbend / genjavadoc

A compiler plugin for generating doc’able Java source from Scala source
Other
58 stars 32 forks source link

support Scala 2.12.16 (and 2.12.17 nightlies) #313

Closed SethTisue closed 2 years ago

raboof commented 2 years ago

I guess we can merge this anyway, since we're not releasing for 2.12.17 yet.

SethTisue commented 2 years ago

@raboof I'll investigate issues you raise (good eye!), but they aren't new in 2.12.16; I just copied the patch file from the 2.12.15 release. (I'll need to do some digging to figure out which 2.12.x version(s) were the actual starting point.)

given that, I suggest you go ahead and release anyway, and if my investigation determines that we need to make changes to genjavadoc, we'll do that later.

SethTisue commented 2 years ago

oh, I see that you did publish 👍

okay, I'll get back to this

raboof commented 2 years ago

@raboof I'll investigate issues you raise (good eye!), but they aren't new in 2.12.16; I just copied the patch file from the 2.12.15 release. (I'll need to do some digging to figure out which 2.12.x version(s) were the actual starting point.)

aah didn't notice that - great if you can look into it!

given that, I suggest you go ahead and release anyway, and if my investigation determines that we need to make changes to genjavadoc, we'll do that later.

agreed, already done!

SethTisue commented 2 years ago

so it turns out that the two questionable methods are there even in src/test/resources/patches/2.12.3.patch, so whatever the problem is, it's quite ancient

given that, I'm not motivated to investigate further. if it had been something that changed in Scala in the last 1–2 years, say, I might have been interested because I'd want to see if it was a Scala regression. but this looks more like a quality problem with genjavadoc. unless it's showing up in the Akka docs and confusing actual users, it doesn't seem worth digging into further