Closed octonato closed 2 years ago
LGTM
Although there are two things I don't quite get.
- I can still see
minimatch 3.0.4
all over the place but now the build passes.- How did you find what to change? I guess you didn't use https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides on the package.json.
I don't expect you to explain 1. but how about 2.?
If you run npm audit --production
in the sdk folder you get the error and the hint to fix.
To fix it, you run npm audit fix
.
My understanding is that minimatch
is transient dependency and instead of overriding it in package.json, the command modifies the lock file. And I'm guessing that it also takes the opportunity to do some clean-up.
I don't know what is the best way of doing it. I'm just trusting that the recommendation of using npm audit fix
is a solid one.
Maybe @katsutoxin can gives us some hints on this?
Anyway, I would like to merge it because it's blocking the build. @katsutoxin, if you believe this is sub-optimal, I can revert and PR again.
Build is failing https://app.circleci.com/pipelines/github/lightbend/kalix-javascript-sdk/1370/workflows/52ebe57d-137d-4763-ba2e-a17a2e17bf1b/jobs/8737?invite=true#step-106-3
This PR fixes it.