lightbend / kalix-jvm-sdk

Java and Scala SDKs for Kalix
https://docs.kalix.io/java/index.html
Other
58 stars 39 forks source link

feat: Support ScalaPB generated envoy validation #695 #2088

Closed johanandren closed 6 months ago

johanandren commented 6 months ago

References

johanandren commented 6 months ago

Not sure if we should make it more official and add to docs or if this is enough for now. Setting it up was kinda tricky to get right so that could be an argument for showing it off in docs.

johanandren commented 6 months ago

Curiously we generate all the message classes twice, once for main/prod and once for test (noticed when tests classes weren't validated), seems like something we should look into at some point.

Couldn't think of a reasonable way to trigger the validation failure from a test since the pb generated classes don't allow invalid message creation.