search

lightbend / kalix-jvm-sdk

Java and Scala SDKs for Kalix
https://docs.kalix.io/java/index.html
Other
58 stars 39 forks source link

feat: include sdk deps in parent pom #2141

Closed efgpinto closed 5 months ago

efgpinto commented 5 months ago

Close #2140

This PR:

efgpinto commented 5 months ago

@ennru @octonato see https://github.com/lightbend/kalix-jvm-sdk/pull/2141/commits/0324807deebb1041cbeea7e69be9cd05386f7d15 ... all junit deps removed, CI still happy. Those dependencies must be being included transitively on the testkit.

efgpinto commented 5 months ago

Confirmed:

[INFO] \- io.kalix:kalix-spring-boot-starter-test:jar:1.4.1-21-458f55cd-dev:test
[INFO]    \- io.kalix:kalix-java-sdk-spring-testkit:jar:1.4.1-21-458f55cd-dev:test
[INFO]       +- io.kalix:kalix-java-sdk-protobuf-testkit:jar:1.4.1-21-458f55cd-dev:test
[INFO]       |  +- junit:junit:jar:4.13.2:test
[INFO]       |  |  \- org.hamcrest:hamcrest-core:jar:2.2:test
[INFO]       |  +- org.junit.jupiter:junit-jupiter:jar:5.10.2:test
[INFO]       |  |  +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO]       |  |  |  +- org.opentest4j:opentest4j:jar:1.3.0:test
[INFO]       |  |  |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO]       |  |  +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO]       |  |  \- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO]       |  +- org.junit.vintage:junit-vintage-engine:jar:5.10.2:test
[INFO]       |  |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test**

I think we are good then.