search

lightbend / kalix-jvm-sdk

Java and Scala SDKs for Kalix
https://docs.kalix.io/java/index.html
Other
58 stars 39 forks source link

Deprecation Warnings 'Using 'entity_type: ...' is deprecated, replace it with 'type_id: ...' on protos using `type_id` #2166

Closed visma-alexander-maslov closed 4 months ago

visma-alexander-maslov commented 4 months ago

For al protos which already use type_id deprecation warning is emitted.

I think this is because of https://github.com/lightbend/kalix-jvm-sdk/blob/24c21b3b35d2c81591920b958c92b243b097847b/codegen/core/src/main/scala/kalix/codegen/ModelBuilder.scala#L687

most probably it needs to be changed to 

val typeId = getTypeId(entityDef.getEntityType, entityDef.getTypeId)

as warning comes from https://github.com/lightbend/kalix-jvm-sdk/blob/24c21b3b35d2c81591920b958c92b243b097847b/codegen/core/src/main/scala/kalix/codegen/ModelBuilder.scala#L788-L795

johanandren commented 4 months ago

Thanks for letting us know!