lightbend / mesos-spark-integration-tests

Mesos Integration Tests on Docker/Ec2
16 stars 9 forks source link

add port check code for mesos dispatcher #19

Closed skonto closed 8 years ago

skonto commented 9 years ago
dragos commented 8 years ago

This is pretty old. Any reason why nobody had a look yet?

dragos commented 8 years ago

I'll do it now :)

dragos commented 8 years ago

Except for formatting, it looks good to me. I know this is annoying, but let's try to keep a consistent feel in the code base. A good start is the official Scala code style

skonto commented 8 years ago

i have used http://www.scalastyle.org/ in the past which enforces style (not the official one) and found it really good for code quality and for jenkins reporting. I will fix that.

dragos commented 8 years ago

Lovely! LGTM