Closed skonto closed 8 years ago
Can you also update the generated index.html
file, to contain links to zookeeper and marathon if launched?
spark.zk.uri
should be added to application.conf.template
.
Zk is not the default master so its optional and its uri is generated only when needed and added to the file no reason to stay around empty... By the way it cannot be empty in conf, config library does not allow keys without values... if it has a replaceable value then it does not help much as you will have to parse it. For example: docker.host.ip = "replace_with_docker_host_ip" This is going to be replaced anyway, spark.zk.uri will not. Anyway this is my argument please lets not leave this pending :) .
I will update the index.html file.
I think its ok now check pls. Index.html updated.
One small style observation, otherwise LGTM.
yes i was about to delete them... merge left overs... i will fix it
done... should i merge it?
go for it!