lightbend / mesos-spark-integration-tests

Mesos Integration Tests on Docker/Ec2
16 stars 9 forks source link

add zk & marathon #50

Closed skonto closed 8 years ago

skonto commented 8 years ago
skyluc commented 8 years ago

Can you also update the generated index.html file, to contain links to zookeeper and marathon if launched?

skyluc commented 8 years ago

spark.zk.uri should be added to application.conf.template.

skonto commented 8 years ago

Zk is not the default master so its optional and its uri is generated only when needed and added to the file no reason to stay around empty... By the way it cannot be empty in conf, config library does not allow keys without values... if it has a replaceable value then it does not help much as you will have to parse it. For example: docker.host.ip = "replace_with_docker_host_ip" This is going to be replaced anyway, spark.zk.uri will not. Anyway this is my argument please lets not leave this pending :) .

skonto commented 8 years ago

I will update the index.html file.

skonto commented 8 years ago

I think its ok now check pls. Index.html updated.

dragos commented 8 years ago

One small style observation, otherwise LGTM.

skonto commented 8 years ago

yes i was about to delete them... merge left overs... i will fix it

skonto commented 8 years ago

done... should i merge it?

dragos commented 8 years ago

go for it!