lightbend / reactive-cli

https://developer.lightbend.com/docs/lightbend-orchestration/current/
Apache License 2.0
23 stars 16 forks source link

Change config key used for Cluster Bootstrap Discovery Method #173

Closed TimMoore closed 5 years ago

TimMoore commented 6 years ago

This currently sets the akka.discovery.method config setting to kubernetes-api or marathon-api, depending on the deployment target:

https://github.com/lightbend/reactive-cli/blob/a4b0a24ad2269e6dda55b7af4ebda81c062a86f1/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/PodTemplate.scala#L74-L92

https://github.com/lightbend/reactive-cli/blob/08addd9d3fd431fa5eb05f23c8948a8f87b57366/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariables.scala#L54-L66

These globally sets the default discovery method to an implementation that is only appropriate to use for Cluster Bootstrap and not for inter-service discovery. This will cause problems for Akka gRPC users, and in the future, all Lagom users.

This should be updated to set akka.management.cluster.bootstrap.contact-point-discovery.discovery-method instead of akka.discovery.method, as described in akka/akka-management#316.