search

lightblue-platform / lightblue-applications

GNU General Public License v3.0
5 stars 8 forks source link

Update response for error status codes (fixes #66) #87

Closed alechenninger closed 9 years ago

alechenninger commented 9 years ago

66

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 22.22% when pulling 56391cf25dc6ad970ba7d6efe6749d14b62e7dd1 on alechenninger:handle-errors into 74ae58c3f2cd82fda61126fa7386d9aec78a5d20 on lightblue-platform:master.

dcrissman commented 9 years ago

Change seems simple enough. Is there anyway I could test this?

alechenninger commented 9 years ago

You can download the app and deploy it. If you have a static http server available (I think python comes with SimpleHTTPServer, ie python -m SimpleHTTPServer 8000), you can just serve up the src/main/webapp directory and use that.

There aren't many tests for this app right now unfortunately, haven't had time to add any.

This is essential for the next release to prod, the app is kind of broken without it. I saw the versions were just bumped for this repo. Does that mean this won't get into the next release?

dcrissman commented 9 years ago

Thanks @alechenninger I was able to test in the way you described. Looks good, so I will merge.

dcrissman commented 9 years ago

The issue #66 was marked for the Bill release, so unfortunately this did not get in before Ana was cut.