search

lightblue-platform / lightblue-applications

GNU General Public License v3.0
5 stars 8 forks source link

Update dependencies #89

Closed alechenninger closed 9 years ago

alechenninger commented 9 years ago

Related was changing from using angular-strap to angular-ui-bootstrap which is maintained by angular team and much simpler and more angular-y to use. You can see in the code it is a lot simpler.

The first commit is only bower_components, so it can be ignored. The second commit is where I modified app to consume updated deps including the bootstrap directive usage.

alechenninger commented 9 years ago

Use this diff to review (has no bower_components in it): https://github.com/alechenninger/lightblue-applications/commit/f4cf82e5310a78e074637c71b178ba02895adbeb

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 22.22% when pulling f4cf82e5310a78e074637c71b178ba02895adbeb on alechenninger:update-dependencies into 74ae58c3f2cd82fda61126fa7386d9aec78a5d20 on lightblue-platform:master.

alechenninger commented 9 years ago

Another part of the motivation of moving to ui-bootstrap is that the alert component is also easier to use that angular-strap's counterpart, and I want to use this to address #65 .

alechenninger commented 9 years ago

As part of the environment dropdown dependency refactor I added the ng-cloak directive to the dropdown. This helps address the ugliness that can happen as mentioned in #91 .

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 22.22% when pulling 22628d897cbea1d8097f951fc5a6156e3c1c3a0b on alechenninger:update-dependencies into 74ae58c3f2cd82fda61126fa7386d9aec78a5d20 on lightblue-platform:master.

dcrissman commented 9 years ago

It feels like this is a more complicated PR than the subject would indicate. Should this possibly be multiple PRs?

alechenninger commented 9 years ago

I don't think so really. It just looks big because I changed / removed a bunch of dependencies. Updating dependencies involved finding compatible versions for everything. The original plugin for the dropdown select made that more complicated than it had to be, so I changed out that dependency for a different one. Now the dependencies are much simpler. And changing out that dependency actually only involved removing code. The only code that was added was one directive, "ng-cloak" on the dropdown.

alechenninger commented 9 years ago

You can see what "really" changed from this single commit: https://github.com/alechenninger/lightblue-applications/commit/f4cf82e5310a78e074637c71b178ba02895adbeb

alechenninger commented 9 years ago

Well, sorry, I lied a little. I had to change the index template a little bit for the new dropdown directive but, it's a very simple change, mostly rearranging what was already there.

alechenninger commented 9 years ago

poke, nudge ... is anyone looking at this? Are there any questions? I'm waiting on this for some usability improvements that will need the angular-ui-bootstrap dependency which was swapped in.