lightblue-platform / lightblue-client

GNU General Public License v3.0
5 stars 24 forks source link

fixes #298 - configure Execution globally #300

Closed dcrissman closed 8 years ago

dcrissman commented 8 years ago

Execution values can now globally be set in lightblue-client.properties, but can be overridden if set directly on the request.

paterczm commented 8 years ago

Seeing a lot of unrelated changes, refactorings probably. Could you make those at least in a separate commit?

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.6%) to 67.381% when pulling 7940717efa2116d96e97cb7888e0f8c709ce9816 on dcrissman:issue298 into 26af36d6beb080affe6ac486bd777ffc68a8906c on lightblue-platform:master.

dcrissman commented 8 years ago

Seeing a lot of unrelated changes, refactorings probably. Could you make those at least in a separate commit?

@paterczm - Just in LightblueClientConfiguration, and most of that is because I had my IDE generate the toString/equals/hashCode methods to include the new fields I was adding. Looks like some unnecessary "this." were accidently removed also, but everything else is part of this change.

paterczm commented 8 years ago

Ok, I didn't know what happened with equals.

dcrissman commented 8 years ago

Ready for review

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.6%) to 67.448% when pulling 593edeca581297e7750698662a7f08ea7de17642 on dcrissman:issue298 into e05cf5f371a9391b104ed19d4136c1f53b53b0bb on lightblue-platform:master.

dcrissman commented 8 years ago

@paterczm - Ready for review

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.2%) to 66.684% when pulling 095ca6cd4fef52a9576e527194520155f44b8586 on dcrissman:issue298 into 74b7dc338cfff42483cce6b819b16f8bc7afa5ed on lightblue-platform:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-69.08%) to 0.0% when pulling fb913110036dc0c247b27a48b4bc7cc3adeb4317 on dcrissman:issue298 into e05cf5f371a9391b104ed19d4136c1f53b53b0bb on lightblue-platform:master.