search

lightblue-platform / lightblue-client

GNU General Public License v3.0
5 stars 24 forks source link

remove MongoController from Execution #301

Closed dcrissman closed 8 years ago

dcrissman commented 8 years ago

@paterczm I am thinking we can just get rid of Execution.MongoController. Thoughts?

paterczm commented 8 years ago

It's there to emphasize that those are mongo only options, not applicable to rdbms or ldap. Why do you want to remove it?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.02%) to 69.034% when pulling 284d2b070a3e7e1d5a563bf43e10ad5105b402f7 on dcrissman:shortcut into 26af36d6beb080affe6ac486bd777ffc68a8906c on lightblue-platform:master.

dcrissman commented 8 years ago

It's there to emphasize that those are mongo only options, not applicable to rdbms or ldap. Why do you want to remove it?

Ok, I can understand the argument that we might want different Executions for different backends. So with that in mind, then I question the add* methods that are on Execution. They would not be relevant to other backend types.

dcrissman commented 8 years ago

@paterczm - What if I simply rename Execution in this PR to MongoExecution? Then we just plan to create an LdapExecution or MariaDbExecution if and when they are needed?

paterczm commented 8 years ago

Makes sense. Let's make Execution and MongoExecution it's child.

dcrissman commented 8 years ago

@paterczm - Hows this?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.05%) to 69.067% when pulling 2462c2e8c6c9e5d35fd95c5411bce588ace86825 on dcrissman:shortcut into 26af36d6beb080affe6ac486bd777ffc68a8906c on lightblue-platform:master.