lightblue-platform / lightblue-migrator

GNU General Public License v3.0
3 stars 13 forks source link

Kinda proxy phase support #396

Closed paterczm closed 8 years ago

paterczm commented 8 years ago

Kinda proxy phase means:

  1. writes go to both legacy and Lightblue services,
  2. if write fails in Lightblue, exception is thrown (in dual read phase it is swallowed!),
  3. if write fails in legacy, exception is swallowed (in dual read phase it is thrown!),
  4. reads go only to Lightblue service,
  5. consistency checks are disabled,
  6. all Lightblue timeouts are disabled.

For write operations, legacy is still going to be called first to ensure all generated data (ids, timestamps, etc.) can be passed to shared store. Legacy is still the source of this shared information.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.02%) to 67.813% when pulling 4bef9cdb379e42d7672609bf8ca9d54aa3e1b82a on kindaproxy into 1e8299dd909ca9ac8904c07082bb183bddb50888 on master.

alechenninger commented 8 years ago

LGTM! One comment, but this is about behavior that already existed. Let me know if you want to merge now, or you can merge at will.