search

lightblue-platform / lightblue-puppet

Puppet module for lightblue!
GNU General Public License v3.0
2 stars 11 forks source link

Fixes #121 log4j config #122

Closed dcrissman closed 9 years ago

dcrissman commented 9 years ago

Adds the ability for puppet to configure log4j outside of the embedded default configuration.

This is also a large refactor of existing functionality to ensure that everything acts consistently.

jewzaam commented 9 years ago

Moved back to 'in progress'. This PR contains many changes around how clients are configured. Please pull those out to a separate PR or include additional context in the PR description.

dcrissman commented 9 years ago

@jewzaam You're right, I have too much going on here. I am working to split this into smaller PRs.

dcrissman commented 9 years ago

Per a conversation with @jewzaam I will re-open this PR.

The migrator puppet script up until this point has depended on the client code to provide the absolute paths for all config files. This is the first time (aside from the service script) puppet is actually landing a configuration file for the migrator. This requires a conf directory to place the log4j.properties file in.

Now with landing that file, it now seems inconsistent that other configuration files are not able to be landed as well or in the same directory. That led to a much larger refactor to empower puppet to be able to land everything in a consist directory structure. It is however, still possible to use your own lightblue config files if that is desired.