lightblue-platform / lightblue-rest

Data access layer as service REST API
GNU General Public License v3.0
9 stars 16 forks source link

CID 158695: Concurrent data access violations (GUARDED_BY_VIOLATION) #277

Open jewzaam opened 7 years ago

jewzaam commented 7 years ago

/lightblue-rest/auth/src/main/java/com/redhat/lightblue/rest/auth/jboss/CertLdapLoginModule.java: 158 in com.redhat.lightblue.rest.auth.jboss.CertLdapLoginModule.getRoleSets()()

*** CID 158695:  Concurrent data access violations  (GUARDED_BY_VIOLATION)
/lightblue-rest/auth/src/main/java/com/redhat/lightblue/rest/auth/jboss/CertLdapLoginModule.java: 158 in com.redhat.lightblue.rest.auth.jboss.CertLdapLoginModule.getRoleSets()()
152          * @see org.jboss.security.auth.spi.AbstractServerLoginModule#getRoleSets()
153          */
154         @Override
155         protected Group[] getRoleSets() throws LoginException {
156             LOGGER.debug("staticRoleLoginModule getRoleSets()");
157
>>>     CID 158695:  Concurrent data access violations  (GUARDED_BY_VIOLATION)
>>>     Accessing "options" without holding lock "LdapRolesProvider.class". Elsewhere, "org.jboss.security.auth.spi.AbstractServerLoginModule.options" is accessed with "LdapRolesProvider.class" held 22 out of 25 times.
158             String roleName = (String) options.get(AUTH_ROLE_NAME);
159
160             SimpleGroup userRoles = new SimpleGroup("Roles");
161
162             Principal p = null;
163