search

lightblue-platform / lightblue-rest

Data access layer as service REST API
GNU General Public License v3.0
9 stars 16 forks source link

Move metrics in lbcore #300

Closed svkm102 closed 7 years ago

alechenninger commented 7 years ago

Did a final once over, all I can see is the issue with errors during streaming find requests as mentioned. Otherwise looks good!

derek63 commented 7 years ago

@svkm102 I merged your core PR, but this one has some failing tests. Can you have a look when you have the chance?

Failed tests:   runStreamFindWithParseProblemAndMetrics(com.redhat.lightblue.rest.crud.cmd.FindCommandTest): expected:<1> but was:<0>
  runFindWithInvalidAndMetrics(com.redhat.lightblue.rest.crud.cmd.FindCommandTest): expected:<1> but was:<0>
  runStreamFindWithInvalidAndMetrics(com.redhat.lightblue.rest.crud.cmd.FindCommandTest): expected:<1> but was:<0>
  runFindWithParseProblemAndMetrics(com.redhat.lightblue.rest.crud.cmd.FindCommandTest): expected:<1> but was:<0>