search

lightcouch / LightCouch

CouchDB Java API
www.lightcouch.org
Apache License 2.0
67 stars 70 forks source link

Fix url parameter encoding #55

Closed iddo closed 6 years ago

iddo commented 8 years ago

Fixes issue #52

Please note that this fix has one behavior change that I believe should not affect anyone: Previously you could mix usages of org.lightcouch.URIBuilder#query(String name, Object value) and org.lightcouch.URIBuilder#query(String query) (although I highly doubt that ever worked because it seems there was no proper handling of when to add the ampersand "&" character between the inputs of the two methods). After this commit the behavior is that the latter form (org.lightcouch.URIBuilder#query(String query)) takes precedence.

iddo commented 7 years ago

You can use the version from my fork.

I'm guessing the project mainteners are too busy to review this relatively big fix (although it's very straight forward).

lightcouch commented 7 years ago

@iddo thanks for providing a fix for the issue. I 'm reviewing the changes to make sure it doesn't introduce a breaking change to the previous code. Thanks.