lightdash / dbt2looker

Generate lookml for views from dbt models
https://lightdash.com
MIT License
177 stars 46 forks source link

Filter models on tags before checking empties #92

Open PaddyAlton opened 9 months ago

PaddyAlton commented 9 months ago

See conversation on Add support for ephemeral models.

This separates out the changes that were made in the parser.parse_models function to the order in which tag-based filtering is done. The effect of these changes is to avoid checking models that aren't included by the tag selector (so e.g. placeholder model files that are empty but are not targeted by the tag selector won't cause the entire run to fail).

N.B. this branch is stacked on top of the previous branch, so it contains both sets of changes. It is reliant on the previous changes to make sense.