lightdash / lightdash

Self-serve BI to 10x your data team ⚡️
https://lightdash.com
MIT License
3.94k stars 417 forks source link

Handle SQL runner limit and improve the results table view #11233

Closed joaoviana closed 1 month ago

joaoviana commented 2 months ago

Description

Hide SQL Runner limit on the button.

Always show a 500 limit on the results table, unless the user applies a limit to it which will be lower(?) - this should be clear in the table! (e.g. preview 500 rows or something)

Allow for fine-tuning this limit on the visualization.

The Chart results table should mimic what's being chosen/configured on the chart. For example:

sanjay-sol commented 2 months ago

Hey @joaoviana , Can I work on this ?

joaoviana commented 2 months ago

thank you for your interest @sanjay-sol, but this is a task I'll be taking soon. You're more than welcome to look into other issues here: https://github.com/lightdash/lightdash/issues?q=is%3Aopen+is%3Aissue+label%3A%22%F0%9F%91%8B+open-contribution%22 😄