Adjusting the format of metrics on sql runner (ex. Percentage, currency)

rephus commented 2 days ago

Description

Thread: https://lightdash.slack.com/archives/C02DGV9RWKV/p1726318173680439

Currently, we allow users to format a y axis/series to a percentage, we should allow other options.

Acceptance Criteria:

[ ] I can select other options for formatting when I have a field on the x axis, y-axis/series
[ ] I can change the formatting to a specific prefix + suffix
[ ] I can add a currency formatting
[ ] I can round the values
[ ] I can change the separator if the values are numeric
[ ] When I make these changes, I shouldn't trigger a new query against the warehouse. This should just change the echarts spec with the formatter-related properties/methods

Implementation suggestion

Look into: CustomFormat and use it instead of the enum Format. Perhaps we can have a Popover to further improve this experience? Check table calculations' way of formatting, that will help.

What problem does this solve?

Improves Data visualization, clearer communication of insights gathered

lightdash-bot commented 2 days ago

This issue was mentioned by a user in slack: https://lightdash.slack.com/archives/C04KD95TF0U/p1726239502822199?thread_ts=1726239502.822199&cid=C04KD95TF0U

joaoviana commented 2 days ago

Can already add percentage formatting, updating description

lightdash / lightdash