lightdash / lightdash

Self-serve BI to 10x your data team ⚡️
https://lightdash.com
MIT License
4.01k stars 426 forks source link

We are not showing reference lines in the past or furutre when using weeks #12554

Open rephus opened 18 hours ago

rephus commented 18 hours ago

This looks like it is a different bug, I've been investigating a bit and it seems we return an empty list of fields for the bottom axis https://github.com/lightdash/lightdash/blob/main/packages/frontend/src/hooks/echarts/useEchartsCartesianConfig.ts#L1050 , which is used in getMinAndMaxReferenceLines , I'm not sure if this is only affecting weeks, all dates, or all types.

Originally posted by @rephus in https://github.com/lightdash/lightdash/issues/12553#issuecomment-2490974563