lightdash / lightdash

Self-serve BI to 10x your data team ⚡️
https://lightdash.com
MIT License
4.02k stars 428 forks source link

Support For AWS Athena As Source #3554

Open IstvanM opened 2 years ago

IstvanM commented 2 years ago

Description

Support for Athena

What problem does this solve?

Many startups don't have the budget to run Databricks or Snowflake as their Data Lake solution. Athena is currently the cheapest on the market.

TuringLovesDeathMetal commented 2 years ago

Hey @IstvanM thanks for opening this issue!

We only support verified dbt adapters for now. You can find the list of verified adapters here: https://docs.getdbt.com/docs/supported-data-platforms#verified-adapters

Once Athena gets onto that list, we'll definitely work on adding support for it in Lightdash!

TuringLovesDeathMetal commented 2 years ago

@all-contributors add @IstvanM for ideas

allcontributors[bot] commented 2 years ago

@TuringLovesDeathMetal

I've put up a pull request to add @IstvanM! :tada:

IstvanM commented 2 years ago

Thank you very much!!! This is great!!! Sorry I was not responding fast enough

🚀 🚀 🚀

stale[bot] commented 1 year ago

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

jankatins commented 1 year ago

Still relevant

nicor88 commented 1 year ago

The only blocker to make this happen is the verification of dbt-athena-community (the adapter with the most recent version of dbt).

Related to https://github.com/dbt-labs/dbt-core/discussions/7286 Specifically, the process of verifying a community-based adapter seems a bit unclear.

stale[bot] commented 1 year ago

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

mrshu commented 1 year ago

@nicor88 I guess the verification procedure has been settled now somewhat?

https://docs.getdbt.com/guides/dbt-ecosystem/adapter-development/7-verifying-a-new-adapter

nicor88 commented 1 year ago

@mrshu the verification process is still quite unclear, as in the case of athena the adapter is community based - and all the verified adapters (e.g. see trino), have a company behind.

stale[bot] commented 1 year ago

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

mrshu commented 1 year ago

Thanks @nicor88. Would you estimate it might ever happen?

nicor88 commented 1 year ago

@mrshu Based on the conversations that I had with dbt seems like a dbt community adapter cannot be verified. Still, they are in the process of considering adding trusted adapters - that means that if Lightdash consider the support of "trusted" adapters and if dbt-athena becomes a trusted adapter, then this integration will be possible.

nicor88 commented 1 year ago

@TuringLovesDeathMetal dbt-athena-community became a trusted adapter: https://docs.getdbt.com/docs/trusted-adapters wondering if you plan to support not only verified but also trusted adapters.

cc @owlas

darkcofy commented 1 year ago

would love to have this integration, would make lightdash an easy choice for us if it works with athena

amartinezcortizas commented 1 year ago

One more, would love to have the chance of testing lightdash with athena

ankit-shopflo commented 10 months ago

+1 would love to use lightdash with Athena

SOVALINUX commented 8 months ago

Would love also to upvote the Athena adapter

lightdash-bot commented 3 weeks ago

This issue was mentioned by a user in slack: https://lightdash.slack.com/archives/C07UKBD9KMX/p1730309812277879?thread_ts=1730309812.277879&cid=C07UKBD9KMX