search

lightdesign / LDProgressView

[Stale] A flat or gradient progress view with a simple color setter and customizable options written in pure Core Graphics
MIT License
368 stars 55 forks source link

Respect animate flag in setProgress #12

Closed jefflinwood closed 10 years ago

jefflinwood commented 10 years ago

Currently, in master, in setProgress, the animation timer is called regardless of whether self.animate is YES or NO.

This is an issue for a progress bar that gets reused (for instance, in multi-file upload) - when the progress bar gets reset to zero, it animates down to zero, which is a strange effect.

I have code that fixes the problem, so I'll fork the repo and send along a pull request if this is a fix you want - apologies if I'm misunderstanding how this progress view was meant to be used.

rcdilorenzo commented 10 years ago

No, you're fine. I hadn't thought of the case of resetting it to zero. Send me a pull-request and we'll see if we can get this issue resolved.

jefflinwood commented 10 years ago

Great, it's in issue #13 - thanks!