search

lighterowl / transgui

A fork of Transmission Remote GUI
GNU General Public License v2.0
152 stars 3 forks source link

Keyboard shortcuts are weird on macOS #45

Closed lighterowl closed 1 year ago

lighterowl commented 1 year ago

https://github.com/transmission-remote-gui/transgui/issues/1355#issuecomment-1671764154

Generally, transgui keyboard shortcuts are hardcoded to use Ctrl. The idea is to switch Ctrl to Command when running on macOS, and hope that they don't clash with any globally defined/OS-standard keyboard shortcuts.

Sadly I don't think there's a uniform way to do this in Lazarus, as the widget/action definitions (and those are used a lot here) can have only one ShortCut set, so any solution is going to involve rewriting those at runtime once we realise we're running on macOS.

lighterowl commented 1 year ago

The first build with these changes, which pretty much convert all Ctrl+something keyboard shortcuts to Command+something is available here : https://github.com/xavery/transgui/suites/16011543153/artifacts/913895959

Please try it out and comment.

Smultie commented 1 year ago

Seems to work fine! Thanks for fixing this!