search

lighterowl / transgui

A fork of Transmission Remote GUI
GNU General Public License v2.0
152 stars 3 forks source link

Check for new version: 301 #87

Closed k0ste closed 4 months ago

k0ste commented 5 months ago

Seems account name was changed, can you make a new release to fix this?

Screenshot 2024-06-29 at 13 22 42
pwinn commented 4 months ago

xavery is now @lighterowl, and the client update-checker doesn't seem to handle 301 redirects.

pwinn commented 4 months ago

Looks like about.pas line 198 has the old URL, needs to be changed to 'https://api.github.com/repos/lighterowl/transgui/releases/latest'.

Ideally, lines 198-206 should be updated to handle 301 redirects better, but at least updating the URL will resolve the current issue.

pwinn commented 4 months ago

As far as I can tell, Synapse 40 does not support redirects, so explicit handling of FHttp.ResultCode = 301 would need to be added, or really any ResultCode beginning with 3.

lighterowl commented 4 months ago

Thanks. GitHub was the last place where my old handle was used and I finally decided to change it. Unfortunately, I forgot about my transgui fork which had the URL to my old account baked-in.

As far as I can tell, Synapse 40 does not support redirects, so explicit handling of FHttp.ResultCode = 301 would need to be added, or really any ResultCode beginning with 3.

Yup, looks like it. Interestingly, Free Pascal provides a module called fphttpclient which supports redirects and support for that is even described on the wiki page.

lighterowl commented 4 months ago

5.18.5.f released with the fix. Closing.