search

lighterowl / transgui

A fork of Transmission Remote GUI
GNU General Public License v2.0
152 stars 3 forks source link

`Keep Selections in Tables` GUI option isn't saving to the config file #94

Open garoto opened 3 months ago

garoto commented 3 months ago

And I noticed what appears to me to be conflicting options being saved to transgui.ini file:

KeepSelectionInTables=Unknown and KeepTableSelection=0

This started happening with the f revision of v5.18.5. Can you narrow it down from my poor bug report?

If I toggle the option on and off from the View menu, it works for the current session only.

lighterowl commented 3 months ago

Hi, thanks for the report.

KeepSelectionInTables should be Unknown since that's an auto-generated entry which expresses the keyboard shortcut for the given option. There is no such shortcut for this particular option so this just writes Unknown to the INI file. Also, if you have a look at that file, you'll notice that KeepSelectionInTables is in the Shortcuts section.

KeepTableSelection (in section Interface) is the one you're after, and it should be either 0 or 1 depending on whether the option is disabled or not.

I can't reproduce this myself so perhaps there's something fishy going on with your INI file. Can you spot anything unusual about it, for example multiple Interface sections, maybe?

garoto commented 3 months ago

I will test with a fresh generated ini/config file.

garoto commented 3 months ago

Tested with a new, freshly generated .ini:

https://x0.at/dFxG.mp4 (51megs/x265 file)

Hashes of my windows binary from the releases tab of gh: sha256 0f32adfe742349e13a34d3562c466ecad91c8d97d7ddf2034de9c0f231bd5205 blake3 e6c507fedc4b7450806e25e67d58cb4070bb702bd1095ecf6d267f6676f146be

I mean, the Not keeping the selection was working fine before the f revision landed.

lighterowl commented 3 months ago

Okay, based on that video, I don't think this option does what you're expecting it to. Some of the blame is obviously on me for naming it so poorly as its name really should be Keep selection while sorting. Also, that option first appeared in 5.18.2.f and wasn't present at all in non-f revisions.

The only thing that this does is guaranteeing that the currently selected entry in the table is scrolled to (or not) after sorting, not switching between filters. If that just happened to work when filtering too, then it must've been purely coincidental as the code doesn't do anything about that explicitly.

The idea for this change came from https://github.com/lighterowl/transgui/issues/25 (which caused to always lose the selection when sorting and switch to the topmost entry), and the option to use the old behaviour was added in https://github.com/lighterowl/transgui/issues/63 .