lighthouse-labs / webpack-react-skeleton

5 stars 6 forks source link

:car: add react-router, alias, style #1

Closed alex-wilmer closed 8 years ago

alex-wilmer commented 8 years ago
Sailias commented 8 years ago

@alex-wilmer great PR. Do you think we should put it into master or a new 'react-router' branch? I can create that branch on this project and you can submit that PR to that branch.

alex-wilmer commented 8 years ago

Probably a branch for now.. I think after it gets some use / feedback we can consider if it's better off as the main branch. Should update the readme on master to inform students of a router branch for single page apps.

Sailias commented 8 years ago

@alex-wilmer I agree. I'll add your README enhancements into master. Unfortunately that means you'll have to resubmit your PR as I can't change it's target.

alex-wilmer commented 8 years ago

https://github.com/lighthouse-labs/webpack-react-skeleton/pull/2