Closed guarin closed 8 months ago
FYI @adamjstewart. Would this fix the problem in torchgeo?
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
25894a9
) 84.40% compared to head (7b458e8
) 84.40%.
Files | Patch % | Lines |
---|---|---|
lightly/utils/dependency.py | 75.00% | 4 Missing :warning: |
lightly/models/utils.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Packaging is no longer needed now right?
Packaging is no longer needed now right?
Yes exactly :) Plus we actually verify whether the required classes are there instead of relying on the version.
The change should also speed up importing lightly
in environments where torchvision and/or timm are installed as we now only import them when needed.
Thanks for the quick fix @guarin, glad we'll be able to use future timm versions again!
Changes
This fixes import issues if users have an older version of timm installed. For details see: