draft of PrettyPrintApiException

[MalteEbner]

Description (version 2):

Change ApiException toPrettyPrintApiException(ApiException), which prints it much more nicely (formatting, print relevant part in bold and red). I kept it inheriting from ApiException to ensure that the calling code can still catch it if needed.

Effects

1) Shortens the stacktrace a bit 2) Prints the ApiException more nicely.

Stacktrace still there

We will not overwrite the sys.excepthook, see discussion with Guarin here, as it is too hacky and might cause problems among users of the library.

Screenshots

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 33.33333% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 81.78%. Comparing base (9bda4ee) to head (f5f8f90).

Files	Patch %	Lines
lightly/api/swagger_rest_client.py	29.03%	22 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1520 +/- ## ========================================== - Coverage 82.09% 81.78% -0.31% ========================================== Files 144 144 Lines 6070 6090 +20 ========================================== - Hits 4983 4981 -2 - Misses 1087 1109 +22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[MalteEbner]

Update after discussion with Jeremy:

• Changing an error message to not include traceback is hardly possible, as the traceback is set by the calling functions (on a higher level), not the error message itself. It is only possible by changing global functions, e.g. the https://docs.python.org/2/library/sys.html#sys.excepthook

• Because lightly is a library that might be used by other python code (e.g. customers integrates it into their own python pipeline), we should not change global functions or rely on them being set to something special. Examples:

  • Customer might also want to change the excepthook or rely on certain behaviour
  • Certain python modes (ipython, jupyter notebook) also change the exception behaviour

  Thus the idea is to keep the direction of this draft: Make the error message formatting nicer, but don't mess with global functions and thus keep the traceback. However, we should

  • use the PrettyPrintApiException for all ApiException
  • fix the formatting for the cases that the error code and error reason are not the same
  • remove any changes in the retry.

  Wdyt? @guarin