search

lightmaster / Meteobridge-Weather34-Template

Github repository for the Meteobridge version of the weather34 template
Other
18 stars 10 forks source link

Option to hide DS Hourly Forecast (Hourly Forecast DS instead WU) #32

Closed nicoloconte closed 5 years ago

nicoloconte commented 5 years ago

Hi boys, with forecast3wularge.php, the Hourly forecast is from DS. Is it possible to hide or to change the dataprovider?

Thanks.

weather34 commented 5 years ago

no unfortunately provider info and credits must always be shown and left intact . ethics creates collaboration any removal of this type of info you lose support.. sounds harsh but if you read any api provider generally requests some form of accreditation..

weather underground api does not provide hourly data in their API hence the darksky option

weather34 commented 5 years ago

reworking darksky to same wu layout requires a complete rework of css layout..best just use it as it is..the darksky hour option mixed with wu was not a part of the original so this must be a recent addition , is it not optional ?.

nicoloconte commented 5 years ago

There has been a misunderstanding, I don't wont to hide credits. I would like to hide the hourly link. In my case WU and DS have very different forecast in some cases.

weather34 commented 5 years ago

no misunderstanding just making the point .. is the darksky option not available sorry i dont have access to this version on my iPad . but whalt happens if you change the darksky api key to 123456789

nicoloconte commented 5 years ago

Black popup

image

weather34 commented 5 years ago

sorry perhaps lightmaster will have to answer i recall if wu was used as the forecast data it didnt show any darksky data .. brian

lightmaster commented 5 years ago

as of right now, setting dark sky api key to 11111111111111 (default value) will hide it, assuming you don't want any darksky data at all. Gimme a little bit and I'll have a new setting for whether or not to show the darksky hourly forecast, defaulting to yes but you can change it to no.

nicoloconte commented 5 years ago

as of right now, setting dark sky api key to 11111111111111 (default value) will hide it, assuming you don't want any darksky data at all. Gimme a little bit and I'll have a new setting for whether or not to show the darksky hourly forecast, defaulting to yes but you can change it to no.

Ok great, It worked.

lightmaster commented 5 years ago

Added in c13c37edd56dc399331c8734dbff69f84e7d7199