lightmaster / Meteobridge-Weather34-Template

Github repository for the Meteobridge version of the weather34 template
Other
18 stars 10 forks source link

Almanac Charts on Mobil #39

Closed spatenchb closed 5 years ago

spatenchb commented 5 years ago

Prior to this latest update (5/21/19), a "touch" on a Almanac Chart would bring up a popup box with Date, Hi and Low data points. The popup still works on the desktop (via mouse), but does not work on Mobil (Iphone/Ipad).

Thanks,

Chuck

lightmaster commented 5 years ago

I've been meaning to check that out. Seems that mobile has an issue with displaying both cross hairs and the tooltip. If I can't find a fix to CanvasJS for it, will probably have to turn off one or the other..

weather34 commented 5 years ago

im confused can we have some screenshots of whats missing

i alwys use ipad as tool to crosscheck see below with tooltips a

tooltip

spatenchb commented 5 years ago

695DF5A6-A8AF-4065-A4F3-1C093B78F655 Brian,

It works on your site. If you go to William's site and click on Wind for the month of May - the Tooltip box does not display on Ipad. It still works correctly on my site because I have not updated to the latest commit (Yesterday).

Chuck

lightmaster commented 5 years ago

Very peculiar. On Android, it works perfectly in portrait, but in landscape the bottom crosshair date doesn't move after a certain point

Screenshot_20190522-115510_Chrome Beta Screenshot_20190522-115537_Chrome Beta

lightmaster commented 5 years ago

And now I pulled my site back up and it's working fine again in landscape and portrait

lightmaster commented 5 years ago

Actually, on Android at least, the crosshairs seem to bug out only when the chart is opened portrait, and then rotated to landscape with the chart still open. The crosshairs then won't go past past a point that looks to be the width of the chart in portrait mode.

weather34 commented 5 years ago

ok i found it , william that tooltip script you compiled is really complex revert to back to something near the original just have a dark barkground for tooltip and fixed font color .its a lot of complex code ..im on a desktop and wind almanac is what i used to find missing tootip .rain ,barometer,wind,temperature almanacs have all missing tooltips in desktop .

also animation really lags on the iPad mini but ok on iPad Air2/Pro

3

toolTip:{ fontStyle: "normal", cornerRadius: 4, backgroundColor: "<?php echo $tooltipbackgroundcolor;?>",
fontColor: "#aaa",
fontSize: 11,
toolTipContent: " x: {x} y: {y}
name: {name}, label:{label} ", shared: true, },

spatenchb commented 5 years ago

William, I thought it might be a caching issue. I cleared cache on Safari (Ipad) and went back to your May Wind chart and it does not shown the tip box.

lightmaster commented 5 years ago

toolTip:{ fontStyle: "normal", cornerRadius: 4, backgroundColor: "", fontColor: "#aaa", fontSize: 11, toolTipContent: " x: {x} y: {y} name: {name}, label:{label} ", shared: true, },

I'll take a look at it. Also, toolTipContent is not used there at all cuz shared is turned on.

lightmaster commented 5 years ago

ok i found it , william that tooltip script you compiled is really complex revert to back to something near the original just have a dark barkground for tooltip and fixed font color .its a lot of complex code ..im on a desktop and wind almanac is what i used to find missing tootip .rain ,barometer,wind,temperature almanacs have all missing tooltips in desktop .

The tooltips work fine on my Windows computer. But the crosshairs act a little weird. I'm gonna disable the crosshairs on my monthly wind chart, let me know if the tooltip works fine on it in Mac.

lightmaster commented 5 years ago

Clear cache just to be careful

spatenchb commented 5 years ago

I have done some testing using William's Site. I cleared cached on all browsers - here are the results. Monthly Temperature Module (with Crosshairs disabled): Windows Desktop: Chrome - Tooltip only Firefox - No Tooltip, No Crosshairs Edge - No Tooltip, No Crosshairs

Ipad Pro/Ipad Mini: Animation a little slow on Ipad Mini Safari, Chrome, Firefox - No Tooltip, No Crosshairs

Mac Desktop: Safari - No Tooltip, No Crosshairs Chrome - Tooltip Only, No Crosshairs

I also checked the present Monthly Temperature Module (crosshairs still enabled):

Windows Desktop: Chrome - Tooltip and Crosshairs Working Firefox - No Tooltip, No Crosshairs Edge - Tooltip and Crosshairs both working

Ipad Pro/Ipad Mini: Animation a little slow on Ipad Mini Safari, Chrome, Firefox - No Tooltip, Crosshairs Working

Mac Desktop: Safari - No Tooltip, Crosshairs Working Chrome - Tooltip and Crosshairs Working

lightmaster commented 5 years ago

Check again. There's an issue with CanvasJS's CanvasJS.formatDate function, which incidentally wasn't even needed. Removing that function from all the charts seems to have gotten it working on Firefox and chrome on Windows for me. Lemme know if it's still broken on anything else. All charts are changed on mine to have that function removed.

spatenchb commented 5 years ago

William,

I retested all of those listed above and they are now all working correctly. Look like that fixed it.

Thanks,

Chuck

lightmaster commented 5 years ago

K. I'll push the fix then