lightmaster / Meteobridge-Weather34-Template

Github repository for the Meteobridge version of the weather34 template
Other
18 stars 10 forks source link

Data Point missing in Charts #54

Closed spatenchb closed 5 years ago

spatenchb commented 5 years ago

William, I noticed this morning (July 2 ) that the July 1 Max/Min data is not showing in my July temperature chart. Seems to be fine in all other charts. I checked the Jul.csv and the data is there.

I also checked your site and the data seems to be missing in most of your July charts.

In my case, the cron ran and the data file was written, but the monthlytemperature.php does not seem to be pulling it.

Thanks,

Chuck

hansmestrum commented 5 years ago

Yes I also just noticed it.

lightmaster commented 5 years ago

I figured it out, its an issue with the interval that that chart uses. Gonna check a couple things with all the charts and then push out the change.

lightmaster commented 5 years ago

Wow there are a lot of charts to edit, lol. Making a number of other changes to address issues like how when there's only one day on a line graph, the graph is invisible unless you hover over it. Also fixing some of the formatting variables so the single days will be centered on the graph, rather than on the y axis all the way to the left.

screenshot

spatenchb commented 5 years ago

Glad you found it! Yes, those charts did seem to multiply over the years.

lightmaster commented 5 years ago

It's funny (and annoying, lol) that it's several hours of work to make the dozen or so changes to all the charts, and that one simple image there sums up all of the changes.

Tied up with work for the next bit, but I've got about half the charts fixed. Regardless, need to wait until after midnight to make sure the ternary I added for the markers makes them go away when 2 or more data points exist. Don't want a line chart with a bunch of markers on it, especially with the yearly ones and their hundreds of points, lol.

chrismaltese commented 5 years ago

Thanks for the update, William. Most appreciated!