Closed michielvandergeest closed 4 months ago
Looking at the fix in this PR https://github.com/lightning-js/blits/pull/62 I'm thinking we are maybe solving a problem that doesn't have to exist ..
We can simplify the code and make it (marginally) more performant if we can skip the whole if/else check for the destroy or delete function.
destroy
delete
If we rename the delete() method in src/element.js to destroy() and change all the references we should be good
delete()
src/element.js
destroy()
Looking at the fix in this PR https://github.com/lightning-js/blits/pull/62 I'm thinking we are maybe solving a problem that doesn't have to exist ..
We can simplify the code and make it (marginally) more performant if we can skip the whole if/else check for the
destroyordeletefunction.If we rename the
delete()method insrc/element.jstodestroy()and change all the references we should be good