search

lightning-js / renderer

Lightning 3 Renderer
Apache License 2.0
57 stars 23 forks source link

fix: added support to border and radius for canvas2d #425

Closed pecoram closed 2 weeks ago

pecoram commented 2 weeks ago

there is a problem with the position of the border... on the webgl renderer the border is inside (which I think is wrong or at most to be made configurable) while on the canvas renderer it is centered

wouterlucas commented 2 weeks ago

Nice, thanks for the contribution! I like how you've isolated it in the Canvas implementation and thanks for the extended review @elsassph!

Heads up @jfboeve has been working on a redesign on the shaders/effects portion of the renderer. Stepping away from the Dynamic Shader and having tree shakeable shaders.

One of the topics we discussed is shaders and Canvas2D and we're keeping those separate. Limiting Effects to WebGL1/WebGL2 only as it does do not make sense to combine. Trying to come up with something to caters to both WebGL & Canvas2D would only lead to overly complicated effects definition for only a small number of applicable effects for Canvas2D anyway.

We'll have to refactor this PR a little bit to make it fit with the new effects/shaders structure down the road.