fix: clean up TS errors

anthony9187 commented 6 months ago

Description

This PR cleans up a lot of TS errors throughout the repo in preparation of switching our build step to use the TypeScript compiler. There's a bit of leg work that needs to be done(or maybe just some configuration) before that can happen, so I'd like to get these changes merged, and then capture that switch in a subsequent PR

note: in FPSCounter, I've added .toString() calls to all the numbers since Text wants strings, not numbers. Is this how we'd prefer to do that, or do we want to loosen the children type of Text?

Changes

improves type safety of various components
adds ts-expect-error lines where we're waiting on updates from outside libraries
references the l3-ui-theme-base for the theme type for development

Testing

ensure we're no longer receiving type errors inside the packages/solid workspace, ensure all components render and function as expected

chiefcll commented 6 months ago

I would read all the files... but... I have a life. I'll assume you know what you're doing on this one...

chiefcll commented 6 months ago

@slhay28 can you just test the PR by opening the branch and running storybook

lightning-js / ui-components