search

lightning-js / ui-components

Lightning UI Components for Solid & Blits
https://lightning-js.github.io/ui-components/
Apache License 2.0
11 stars 4 forks source link

Migrate solid #165

Closed chiefcll closed 5 months ago

chiefcll commented 5 months ago

Rewrite all the imports to new solid home.

slhay28 commented 5 months ago

all stories are throwing this error The requested module '/node_modules/.cache/storybook/default/sb-vite/deps/@lightningtv_solid.js?v=1a9e9319' does not provide an export named 'View'.

Is View located somewhere else now?

chiefcll commented 5 months ago

Nope - should still be there. I'll double check this in a bit - you did pnpm i right??

slhay28 commented 5 months ago

yup, reran pnpm i just now also and got same error

anthony9187 commented 5 months ago

seeing the same error, I'll try and dig in a bit

chiefcll commented 5 months ago

Latest version is 0.0.13 - pnpm up wasn't installing it for me when I was doing it. Try setting it in the package and then installing it.

anthony9187 commented 5 months ago

hardcoding the version to 0.0.13 resolved that issue, now I'm seeing some font issues in storybook:

chunk-HLAU6QKI.js?v=79fd5268:55 Uncaught Error: Could not resolve font face for normal 500 normal 25px Arial
    at assertTruthy (chunk-HLAU6QKI.js?v=79fd5268:55:11)
    at CanvasTextRenderer.updateState (chunk-HLAU6QKI.js?v=79fd5268:2104:7)
    at chunk-HLAU6QKI.js?v=79fd5268:1073:12

anything that renders text seems to be effected

chiefcll commented 5 months ago

Ok that is due to renderer 0.9 need to update appcore and how fonts are loaded

On Tue, Jun 4, 2024, 10:47 AM Anthony Gallo @.***> wrote:

hardcoding the version to 0.0.13 resolved that issue, now I'm seeing some font issues in storybook:

chunk-HLAU6QKI.js?v=79fd5268:55 Uncaught Error: Could not resolve font face for normal 500 normal 25px Arial at assertTruthy (chunk-HLAU6QKI.js?v=79fd5268:55:11) at CanvasTextRenderer.updateState (chunk-HLAU6QKI.js?v=79fd5268:2104:7) at chunk-HLAU6QKI.js?v=79fd5268:1073:12

anything that renders text seems to be effected

— Reply to this email directly, view it on GitHub https://github.com/lightning-js/ui-components/pull/165#issuecomment-2147727337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP6PPMB2ETCRIOHAYEXOQDZFXHORAVCNFSM6AAAAABIVBHFECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXG4ZDOMZTG4 . You are receiving this because you authored the thread.Message ID: @.***>

chiefcll commented 5 months ago

OK - should be all fixed. I'll resolve these merge conflicts as well... @slhay28 don't merge anything else 😛

slhay28 commented 5 months ago

looks good!