search

lightning / blips

Bitcoin Lightning Improvement Proposals
132 stars 46 forks source link

bLIP-10: ts property needs to specify time units #12

Open coldacid opened 2 years ago

coldacid commented 2 years ago

While we may all know right now that ts is supposed to be in seconds, there's nothing actually specifying that in the document. Someone could look at it and think that perhaps it's milliseconds. Or perhaps something odd, like the number of frame headers passed in the mp3 file. Long story short, the time unit should be specified explicitly in the doc.

JssDWt commented 2 years ago

This is fixed in https://github.com/lightning/blips/pull/13, so can be closed?

satoshisstream commented 2 years ago

yes

SiddheshKukade commented 1 year ago

Hello @satoshisstream , what does the ts field stands for here does it mean time in seconds OR timestamp? Please explain. image Source: https://github.com/lightning/blips/blob/master/blip-0010.md