search

lightning / bolts

BOLT: Basis of Lightning Technology (Lightning Network Specifications)
2.11k stars 491 forks source link

Unable to change a private channel to make it public #624

Open sohomang opened 5 years ago

sohomang commented 5 years ago

Background

No API command permits to change a private channel to make it public (and vice versa). Some wallets like Zap iOS open channels as private by default and this characteristic seems unalterable for now.

(Opened an issue on lnd and learned it was something handled by the protocol itself. https://github.com/lightningnetwork/lnd/issues/3230)

Your environment

Steps to reproduce

Expected behaviour

A command should exist to let users toggle their channels' privacy settings while they're open/active.

Actual behaviour

Users have to closechannel then openchannel again to reset their private setting, which pollutes the blockchain with 2 transactions.

ZmnSCPxj commented 5 years ago

Toggling seems to not make sense. Once a channel is published it has been published and now exists in the routemap of nodes all over the world.

However, a one-time promotion from unpublished to published would work.

(I do not agree that they are "private" since, as long as they remain unpublished, every transaction going through it is definitely known to arise from/terminate to you, thus not particularly private.)

Czino commented 3 years ago

Has any more consideration been done on this front? I have come across multiple cases, where somebody had to close a private channel just to reopen it as public.

I also don't see any particular issue with having a one way of going from private to public unless there's a good technical reason why this is and should not be possible.

faustinoaq commented 1 year ago

I think we need this, I opened a private channel by mistake (I wanted it public) and now I have to close it and open it again as public 😢

adamj7 commented 4 months ago

Would love to see this implemented. Private > Public 1 way only.

ShahanaFarooqui commented 1 month ago

Reference Core lightning issue: https://github.com/ElementsProject/lightning/issues/7438 Reference LND issue: https://github.com/lightningnetwork/lnd/issues/7902

Roasbeef commented 1 month ago

With the new gossip revamp, we'll again a way to upgrade private channels to public channels, as nodes can optionally choose to advertise their old channels in the new gossip network.