search

lightning2401 / northstar

Inspired by Micdoodle's Galacticraft, Northstar seeks to return players to the stars with the power of the Create mod.
33 stars 11 forks source link

Fix shaders not rendering overworld stars properly #94

Open doonv opened 1 month ago

doonv commented 1 month ago

This fixes a bug where stars would render in the day as black dots while using certain shaders:

Complementary Shaders Reimagined (With Embeddium & Oculus), Current Northstar Version: image

This PR fixes this bug by rendering stars in the same area of code where vanilla stars are rendered (So the stars are rendered are in the same stage as vanilla stars, which makes shaders treat them like vanilla stars), I removed unused code from the renderSky2 mixin and renamed it to renderSkyStarsOverworld.

I also reformatted the entire LevelRendererMixin.java file, which unfortunately makes this PR very hard to review. (sorry, try enabling "Hide Widespace" in the options)

Also flying above Y450 still looks like it did before (with black stars and no earth below), I might fix that in a later PR.