jitrebalance: shouldn't it be static ?

[darosior]

I just crashed my node by stopping jitrebalance via RPC. I could have give it a thought before issuing the command, but making the plugin static would avoid the footgun in the first place : what do you think ?

2020-05-25T09:23:37.816Z INFO plugin-jitrebalance.py: Killing plugin: /home/bitcoin/clightning/plugins/jitrebalance/jitrebalance.py stopped by lightningd via RPC
2020-05-25T09:23:38.356Z **BROKEN** lightningd: Already in transaction from lightningd/io_loop_with_timers.c:31
2020-05-25T09:23:38.970Z **BROKEN** lightningd: FATAL SIGNAL 6 (version v0.8.2)
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: common/daemon.c:44 (send_backtrace) 0x5586d65ea826
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: common/daemon.c:52 (crashdump) 0x5586d65ea876
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7fda1762783f
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7fda176277bb
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7fda17612534
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/log.c:819 (fatal) 0x5586d65bc454
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: wallet/db.c:798 (db_begin_transaction_) 0x5586d6622d08
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/plugin_hook.c:206 (plugin_hook_callback) 0x5586d65df213
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/plugin_hook.c:134 (plugin_hook_killed) 0x5586d65def81
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:240 (notify) 0x5586d664f8d4
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:402 (del_tree) 0x5586d664fdc3
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:412 (del_tree) 0x5586d664fe15
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:486 (tal_free) 0x5586d665014f
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/plugin_control.c:232 (clear_plugin) 0x5586d65de3c6
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/plugin_control.c:248 (plugin_dynamic_stop) 0x5586d65de46b
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/plugin_control.c:318 (json_plugin_control) 0x5586d65de7bb
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/jsonrpc.c:587 (command_exec) 0x5586d65b610c
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/jsonrpc.c:695 (rpc_command_hook_callback) 0x5586d65b65a4
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/plugin_hook.c:277 (plugin_hook_call_) 0x5586d65df5a6
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/jsonrpc.c:772 (plugin_hook_call_rpc_command) 0x5586d65b69c4
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/jsonrpc.c:779 (call_rpc_command_hook) 0x5586d65b69ed
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: common/timeout.c:39 (timer_expired) 0x5586d65fac9d
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/io_loop_with_timers.c:32 (io_loop_with_timers) 0x5586d65b4055
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: lightningd/lightningd.c:984 (main) 0x5586d65b99fb
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7fda1761409a
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x5586d659e9b9
2020-05-25T09:23:38.970Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0xffffffffffffffff

[cdecker]

I'm not sure what I'm looking at. What caused the crash in c-lightning? Surely we should be able to just kill jitrebalance at any time, and in-flight HTLCs would just get rejected, undoing any changes the plugin hasn't committed yet.

[ca-ruz]

@chrisguida This plugin has been archived.

[chrisguida]

Thanks @ca-ruz !

Closing due to jitrebalance being archived.