lightningd / plugins

Community curated plugins for core-lightning
BSD 3-Clause "New" or "Revised" License
269 stars 129 forks source link

jitrebalance crash #148

Closed darosior closed 4 years ago

darosior commented 4 years ago
2020-09-10T06:33:28.150Z INFO plugin-jitrebalance.py: Got an incoming HTLC htlc={'amount': '674395289msat', 'cltv_expiry': 647860, 'cltv_expiry_relative': 294, 'payment_hash': 'ddb6cf9d71dddf198a0f0b44cefd919d6d00521915ec9c7dd0caec893722a7cd'}
2020-09-10T06:33:28.173Z **BROKEN** lightningd: Plugin for htlc_accepted returned non-result response {"jsonrpc": "2.0", "id": 63253, "error": {"code": -32600, "message": "Error while processing htlc_accepted: 'NoneType' object is not subscriptable"}}
2020-09-10T06:33:30.264Z **BROKEN** lightningd: FATAL SIGNAL 6 (version v0.9.0-1)

No traceback. It restrained lightningd from restarting for hours as it would crash on startup, the above is the first crash log.

cdecker commented 4 years ago

Should be fixed upstream: https://github.com/ElementsProject/lightning/commit/bd811fbd1a6f0d3369d0ad62787c2b1c6b9072d6 part of release https://github.com/ElementsProject/lightning/releases/tag/v0.9.1

darosior commented 4 years ago

Nice

https://github.com/ElementsProject/lightning/blob/d56f8b6c5dad414273cf7bb214f7808b7cbb169f/contrib/pyln-client/pyln/client/plugin.py#L478-L483

Guess i'll contact the plugin author then :p