search

lightningd / plugins

Community curated plugins for core-lightning
BSD 3-Clause "New" or "Revised" License
269 stars 129 forks source link

feeadjuster: invalid literal for int() with base 10 (CLN 22.11) #411

Closed swissrouting closed 1 month ago

swissrouting commented 1 year ago

Enabled feeadjuster plugin with this config:

feeadjuster-feestrategy=median
feeadjuster-max-htlc-steps=3

See the following error in CLN logs:

2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py: Traceback (most recent call last):
2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py:   File \"/home/bitcoin/.local/lib/python3.9/site-packages/pyln/client/plugin.py\", line 668, in _dispatch_notification
2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py:     self._exec_func(func, request)
2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py:   File \"/home/bitcoin/.local/lib/python3.9/site-packages/pyln/client/plugin.py\", line 619, in _exec_func
2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py:     ret = func(*ba.args, **ba.kwargs)
2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py:   File \"/home/bitcoin/cl-plugins-available/plugins/feeadjuster/feeadjuster.py\", line 220, in forward_event
2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py:     plugin.adj_balances[in_scid][\"our\"] += int(forward_event[\"in_msat\"])
2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py: ValueError: invalid literal for int() with base 10: '100048602msat'
2022-12-05T23:30:07.316Z INFO    plugin-feeadjuster.py:

Plugins repo version: at HEAD commit 386f2f650b66a9d53fc37169892bdda1cdbc6217 CLN version: 22.11

grubles commented 1 year ago

I was running into this too.

chrisguida commented 1 month ago

Fixed in https://github.com/lightningd/plugins/pull/525