lightningd / plugins

Community curated plugins for core-lightning
BSD 3-Clause "New" or "Revised" License
269 stars 129 forks source link

sauron: crash on start for getchaininfo #516

Closed daywalker90 closed 3 months ago

daywalker90 commented 6 months ago
/sauron.py error: bad response to getchaininfo (bad 'result' field: Parsing '{result:': object does not have member result), response was {"jsonrpc": "2.0", "id": "cln:getchaininfo#19", "error": {"code": -32600, "message": "Error while processing getchaininfo: Retry.__init__() got an unexpected keyword argument 'method_whitelist'", "traceback": "Traceback (most recent call last):\n  File \"/home/bitcoin/lightning/contrib/pyln-client/pyln/client/plugin.py\", line 646, in _dispatch_request\n    result = self._exec_func(method.func, request)\n             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/bitcoin/lightning/contrib/pyln-client/pyln/client/plugin.py\", line 626, in _exec_func\n    ret = func(*ba.args, **ba.kwargs)\n          ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/bitcoin/plugins/sauron/sauron.py\", line 77, in getchaininfo\n    genesis_req = fetch(blockhash_url)\n                  ^^^^^^^^^^^^^^^^^^^^\n  File \"/home/bitcoin/plugins/sauron/sauron.py\", line 28, in fetch\n    retry_strategy = Retry(\n                     ^^^^^^\nTypeError: Retry.__init__() got an unexpected keyword argument 'method_whitelist'\n"}}

While trying to write a test for this was already difficult (pyln-testing always adds a bitcoind specific option when starting a node, that can't be removed so i had to edit pyln-testing, maybe there is another way tho), CLN 24.02.2 just would not start successfully because of the error above.

chrisguida commented 6 months ago

Sauron sort of doesn't really have a maintainer right now, trying to see if we can find one...

https://github.com/lightningd/plugins/pull/471#issuecomment-1932383927