Make `Str`'s `clone` always clone the underlying bytes

lightningdevkit / ldk-c-bindings

Main LDK C Bindings on which other bindings are built

Other

13 stars 14 forks source link

Make `Str`'s `clone` always clone the underlying bytes #71

Closed TheBlueMatt closed 2 years ago

TheBlueMatt commented 2 years ago

Its incredibly unexpected that you can clone a higher-level object (eg an Event with a ClosureReason that contains an Str) and have a pointer back to the original object. To avoid this, clone needs to actually clone.