search

lightningdevkit / ldk-node

A ready-to-go node implementation built using LDK.
Other
147 stars 73 forks source link

Consider including gossip data field in `list_channels` #234

Open tnull opened 8 months ago

tnull commented 8 months ago

While LDK's ChannelManager doesn't have immediate access to gossip data, LDK Node does.

We therefore at least could consider to add additional (gossip) data fields to the ChannelDetails returned from list_channel, e.g., the counterparty's node announcement, allowing the user to access the node alias for displaying purposes.

reez commented 8 months ago

Thanks would love node alias!

tnull commented 8 months ago

Mh, thinking about it again it's pretty tricky to this reliably on 'mostly-offline' nodes such as mobile devices, as RGS won't ship us any node announcements. So the optional field in ChannelDetails would be very unreliable, and only populated after we happen to receive a rebroadcast of our counterparty's node announcement.